scverse / scverse/scanpy

filter_rank_genes_groups much slower than rank_genes_groups

Open
#1,514 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
2.6k
Forks
779
Avg merge
1d 4h
Merged PRs (30d)
27

Description

I was using Scanpy 1.5.0
It took me more than two hours to finish filter_rank_genes_groups with default parameters while rank_genes_groups takes less than 5 minutes.
But theoretically, it shouldn't be too different from rank_genes_groups right?
But it seems way slower than rank_genes_groups and much slower than Seurat.
Is there a way to make it faster?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the reported timing difference between filter_rank_genes_groups and rank_genes_groups in Scanpy 1.5.0 using their default parameters. Compare the two function entry points and identify where the extra runtime occurs; done means the performance difference is explained and a faster, validated behavior is demonstrated.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data, performance
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.