Should log1p edit .X inplace?
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 2.6k
- Forks
- 779
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 27
Description
It's a little confusing why something like normalize_total doesn't inplace edit the data, but log1p does.
Why should out be set here?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with scanpy/preprocessing/_simple.py around lines 309-321 and compare log1p with normalize_total, focusing on how the out argument affects .X. Review the existing comments and relevant preprocessing tests, if present. Done means the intended in-place behavior is resolved and consistently documented or covered by tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100