scverse / scverse/scanpy

Violin plot doesn't have option to return figure and doesn't check if the paths is an absolute path

Open
#1,040 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
2.6k
Forks
779
Avg merge
1d 4h
Merged PRs (30d)
27

Description

Hi guys,

Would it be possible to amend the behaviour of sc.pl.violin() to act more like the clustering plots, where there is a 'return_fig' option.

Alternatively, you could check whether the str provided to the 'save=' arg contains an existing directory path and if so not append to the front of the path.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the sc.pl.violin() entry point and compare its behavior with the clustering plots that already support return_fig. Trace how the save= argument is handled, then verify that the chosen behavior supports returning the figure and preserves an existing absolute directory path.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data-visualization
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.