scverse / scverse/napari-spatialdata

Support both `r`, `g`, `b` and `R`, `G`, `B` for displaying images

Open
#382 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
90
Forks
25
Avg merge
22m
Merged PRs (30d)
1

Description

IMHO, since intuitively acronyms are associated with upper-case initials, I would make this case-insensitive.

Originally posted by @gboscagli in #371

In napari-spatialdata we differentiate between multichannel images and RGB images via the name of the channels. When channels are r, g, b they are interpreted as RGB images. @gboscagli suggests to make this check case-insensitive.

Tagging devs working on other viewers. WTYT? @timtreis @sonja-stockhaus @keller-mark

I'm fine making it case-insensitive.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search the napari-spatialdata code for the channel-name check that distinguishes r, g, and b from multichannel images. Update the check to accept both letter cases, then verify that lowercase and uppercase RGB channel names display as RGB images while other channel names remain multichannel.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data-visualization
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.