scverse / scverse/napari-spatialdata

NaN values colored if non-NaN values are only one

Open
#238 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
90
Forks
25
Avg merge
22m
Merged PRs (30d)
1

Description

When the table misses some instances or contains NaN values, colors are not mapped. Specifically if:

  • The table contains less instances than the segmentation image in labels
  • Or an observation column or X column contains NaN (because missing values have been filled up).

Actual behavior:

If an obs/X column contains NaN and the non-NaN values are all the same, all labels are visualized with color, as if it ignores the fact that some are NaN.

Expected behavior:

It does not color values that are NaN.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. Start by reproducing the described NaN and single-non-NaN-value cases in the color-mapping path, checking both observation/X columns and tables with fewer instances than the segmentation image; done means NaN values remain uncolored in each case.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data-visualization
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.