scverse / scverse/SnapATAC2

computing p-value associated with the snapatac2.tl.add_cor_scores output.

Open
#218 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement :sparkles:
Dominant language
Python
Stars
323
Forks
43
PR merge metrics
No merged PRs in 30d

Description

Dear Kai,

Thanks again for the amazing work! I came to notice that there wasn't any p-value calculated when using the add_cor_scores function. Is it possible to add this feature in the future? Much appreciated!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the snapatac2.tl.add_cor_scores entry point and trace how its correlation scores are calculated and returned. Clarify the intended p-value definition and output before implementation; done means p-values are exposed alongside the scores and the relevant project checks pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.