scverse / scverse/PyDESeq2

Use `AnnData` as a component rather than a superclass of `DeseqDataSet`

Open
#331 3 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Python
Stars
761
Forks
90
Avg merge
25m
Merged PRs (30d)
10

Description

This would offer more flexibility and robustness wrt future AnnData development.

E.g., as pointed out by @grst, his would also allow storing the anndata if the user has stored that elsewhere, and using lazy loading on the h5ad which is not possible using pickle.

Beside, composition is usually better practice than inheritance.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the DeseqDataSet implementation and understanding how it currently inherits from AnnData. Review the existing serialization and loading behavior, especially the stated pickle and lazy-loading limitations. Done means the relationship is changed to composition while preserving the class’s existing behavior and supporting externally stored or lazily loaded AnnData.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
bioinformatics
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.