scroll-tech / scroll-tech/frontends
[BUG] Loading state is overlapping with No data state in the 'Transactions History' Dialog on bridge page
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 63
- Forks
- 79
- Avg merge
- 16h 15m
- Merged PRs (30d)
- 10
Description
Describe the bug
On the bridge page, when you click on the 'Transactions History' button and the dialog opens, the loading state overlaps with the No data state. It needs segregation.
To Reproduce
Steps to reproduce the behavior:
1- Go to the Bridge page on the Scroll app
2- Click on 'Transactions History' button
3- The dialog opens
4- If there are no transactions, the loading icon overlaps with the No-data state
Expected behavior
Screenshots
Desktop (please complete the following information):
- OS:
- Browser
- Version
Smartphone (please complete the following information):
- Device:
- OS:
- Browser
- Version
Additional context
I have created a pull request for the above mentioned fix.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the Bridge page's Transactions History button and dialog in the Scroll app, then reproduce the empty-history case described in the issue. Trace how the loading and No data states are rendered; done means the loading indicator no longer overlaps the empty state.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100