scroll-tech / scroll-tech/ceno
`EANY` should disappear as a kind, and be replaced with `ECALL` and `EBREAK`.
@naure is already working on this.
Since Nov 4, 2024.
- Dominant language
- Rust
- Stars
- 153
- Forks
- 43
- Avg merge
- 3d 13h
- Merged PRs (30d)
- 4
Description
Risc0 uses an idiosyncratic decoding process. That forces them to introduce a new instruction kind, EANY that doesn't appear anywhere in the Risc-V spec. We inherited that limitation when we copy-and-pasted their code.
I suggest we remove EANY and replace it with ECALL and EBREAK, instructions that are actually mentioned in the spec.
EANYshould disappear as a kind, and be replaced withECALLandEBREAK.
EANYain't even an instruction that appears in Risc-V. It's just an artifact of Risc0's design decisions.(But we can do that in a subsequent PR.)
Originally posted by @matthiasgoergens in https://github.com/scroll-tech/ceno/pull/538#discussion_r1827188404
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.