scribe-org / scribe-org/Scribe-iOS

Fix noun article on annotation press

Open
#302 8 comments 0 reactions 1 assignee View on GitHub

@andrewtavis is already working on this.

Since May 12, 2023.

-priority- help wanted
Dominant language
Swift
Stars
169
Forks
109
PR merge metrics
No merged PRs in 30d

Description

Terms
Description

Amazing feature idea that came up via showing Scribe to a coworker 🎉 It would be great if we added a feature where pressing the noun annotation would check to see if there’s an article before it and if so if it’s the incorrect article. If it’s not correct then the word and the article can then be replaced with the correct one and the word after it 😊

Things to consider:

  • We’d need to make sure the key gets the shadow, which I believe comes from the active state regardless
  • For words that are both nouns and prepositions the article correction would first be triggered and then if the article is correct we could do preposition pronoun selections
  • It’d be good if the replacement was matched with an indicator to the user, with the current working thought being that we could display a checkmark icon on the annotation for a moment before reverting back to the annotation

This feature would definitely be worth a release for v2.4 🚀

Contribution

I’ll start working on this soon and would be happy to get some support :)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.