scratchfoundation / scratchfoundation/scratch-desktop

All dialogs are unlocalized

Open
#340 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
426
Forks
268
Avg merge
16h 6m
Merged PRs (30d)
25

Description

Expected Behavior

All dialogs are unlocalized

Steps to Reproduce

Try to close application window. Leaving dialog uses dialog.showMessageBoxSync (src/main/index.js:361). There is no way to get it localized like menu. Please, use wrapper function for generate string for localization as in gettext().

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/main/index.js at the dialog.showMessageBoxSync call around line 361, then inspect how menu strings use the localization wrapper such as gettext(). Identify the application dialogs that still bypass localization and route their displayed strings through the same approach. Done means dialogs, including the close-application dialog, display localized text.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
desktop, localization
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.