scratchfoundation / scratchfoundation/scratch-desktop

Save dialog doesn't expand when clicking the down caret button on mac

Open
#28 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug mac
Dominant language
JavaScript
Stars
426
Forks
268
Avg merge
16h 6m
Merged PRs (30d)
25

Description

The first time you save a project on a mac the dialog is small, showing you only a title field, tags, and a "where" section that only shows limited number of locations.
screen shot 2019-01-09 at 10 49 26 am

If you click the "Down Carrot" button to the right of the Where section it should expand to show a full file browser, but it does not. Canceling and re-choosing save brings up the full file browser version of the save dialog.

Attempting to switch to the smaller version of the dialog has a similar response, where it doesn't change the size but goes through a partial state change. Canceling and opening it again brings up the dialog in the state you had just switched to.

Steps to reproduce

Open the offline editor
Choose File > Save to your computer
Note: the small dialog appears
Click the down carrot button screen shot 2019-01-09 at 10 53 02 am
Note: The dialog does not get any bigger. The "new folder" button appears and the down carrot becomes an up carrot button. Also the word Where disappears.
screen shot 2019-01-09 at 10 53 33 am
Click cancel on the dialog
Note: Very briefly the window expands and then disappears with an animation
Choose File > Save to your computer again
Note: the full size save dialog appears
Click the "Up Carrot" button
Note: the file browser disappears but the window does not shrink
Click Cancel
Note: the dialog shrinks quickly and the goes away
Click File > Save one more time
Note: the regular, smaller dialog appears.

Operating System

Mac

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the save flow in the offline editor on macOS, starting with File > Save to your computer and the down/up caret transitions. Inspect the save-dialog implementation and verify that expanding and collapsing update the window size and file-browser state immediately, without requiring cancellation and reopening.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.