scratchfoundation / scratchfoundation/scratch-desktop
`onHasInitialProject` is too complex
Open
@cwillisf is already working on this.
Since Sep 29, 2020.
developer facing
enhancement
tech debt
- Dominant language
- JavaScript
- Stars
- 426
- Forks
- 268
- Avg merge
- 16h 6m
- Merged PRs (30d)
- 25
Description
This is a tracking issue for addressing review feedback: https://github.com/LLK/scratch-desktop/pull/150#pullrequestreview-498023241
Expected Behavior
Items in mapDispatchToProps should be pass-through functions to dispatch when possible.
Actual Behavior
The onHasInitialProject function in src/renderer/app.jsx includes some logic to determine which of two dispatch calls to make. This logic should be moved to the caller so that it's easier to see all the relevant logic in one location.
CC @benjiwheeler
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.