scratchfoundation / scratchfoundation/scratch-blocks

Layers block displays negative numbers incorrectly in RTL languages

Open
#2,387 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

High Prevalence High Severity localization priority 2
Dominant language
JavaScript
Stars
2.8k
Forks
1.6k
Avg merge
4h 51m
Merged PRs (30d)
12

Description

Expected Behavior

Negative numbers in RTL languages still display the minus sign on the left of the number in the go forward/backward (n) layers block.

Related to #2043 (negative numbers in boolean blocks), #2386 (set variable negative number), and #1707 (negative sign is incorrect when editing a numeric value), but keeping them separate since fixing one block may not fix the others.

Actual Behavior

Negative sign is on the right instead of the left.
Screen Shot 2021-04-13 at 12 48 00 PM

Steps to Reproduce

Switch to Persian (Farsi) in the language menu

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue by switching Scratch Blocks to Persian and using the go forward/backward (n) layers block. Inspect that block's handling of negative numbers and compare it with the related RTL issues #2043, #2386, and #1707. Done means the minus sign appears on the left of the number in RTL languages.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
internationalization
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
40/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.