scratchfoundation / scratchfoundation/scratch-blocks

It takes two undo/redo steps to undo/redo the duplication of a block stack

Open
#2,089 0 comments 0 reactions 1 assignee View on GitHub

@adroitwhiz is already working on this.

Since Jul 16, 2020.

Low Prevalence Low Severity priority 4
Dominant language
JavaScript
Stars
2.8k
Forks
1.6k
Avg merge
4h 51m
Merged PRs (30d)
12

Description

Expected Behavior

When you duplicate a block stack and then undo, you should only need to undo once to delete that block stack.

Actual Behavior

The first time you undo after placing a duplicated block stack, it will move the duplicated stack directly on top of the original stack. The second undo actually deletes the duplicated stack.

Likewise for redoing: the first redo creates a duplicated block stack on top of the original stack, and the second redo moves it to the proper position.

Steps to Reproduce
  1. Right-click a block stack
  2. Click "duplicate"
  3. Place the new block stack somewhere (either attach it to another stack, or put it on the workspace)
  4. Right-click the workspace and click "undo" (once)
  5. Drag the stack that you duplicated, and observe that there are actually now two stacked copies of it
  6. Repeat the process, but this time, click "undo" twice
  7. Observe that the stack is now properly deleted
Operating System and Browser

All

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.