scratchfoundation / scratchfoundation/scratch-blocks
Undoing removing a block which had a comment attached does not restore the comment
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 2.8k
- Forks
- 1.6k
- Avg merge
- 4h 51m
- Merged PRs (30d)
- 12
Description
Expected Behavior
Undoing anything that gets rid of a block should make the block and attached comments come back.
Actual Behavior
Undoing doesn't restore comments!
Steps to Reproduce
- Create a new project and drag a block out into the workspace.
- Attach a comment to the block (right click -> add comment).
- Drag the block back into the palette. This should delete the comment too.
- Press ^-Z to undo. Note that the comment is not restored.
Operating System and Browser
Firefox 67.0b15, Linux (Debian).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue in a new project using the block, attached comment, palette removal, and undo steps described above. Trace how removing a block records undo state and how attached comments are handled; done means undo restores both the block and its comment in Firefox on Linux.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100