scratchfoundation / scratchfoundation/scratch-blocks
Comments not deleted/undeleted on keyboard shortcuts
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 2.8k
- Forks
- 1.6k
- Avg merge
- 4h 51m
- Merged PRs (30d)
- 12
Description
Expected Behavior
- When I click on a block comment, and then press the "delete" key, it should delete the comment. Then pressing Ctrl+Z should undelete it.
- When I click on a workspace comment, and then press the "delete" key, it should delete the comment. Then pressing Ctrl+Z should undelete it.
Actual Behavior
-
When I click on a block comment, and then press the "delete" key, it deletes both the block and the comment. When I press Ctrl+Z, it only undeletes the block, not the comment.
-
When I click on a workspace comment, and then press the "delete" key, it doesn't delete the comment, but instead deletes the last block I had focused on.
Operating System and Browser
Mac OS, Google Chrome
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the block-comment and workspace-comment cases in Mac OS with Google Chrome, then trace the keyboard Delete and Ctrl+Z handling for both comment types. Done means deleting a selected comment does not delete an unrelated block, and undo restores the comment in each case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100