scratchfoundation / scratchfoundation/scratch-blocks
Some fields have dispose_ method but it probably should be dispose
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 2.8k
- Forks
- 1.6k
- Avg merge
- 4h 51m
- Merged PRs (30d)
- 12
Description
While making the note picker field @ericrosenbaum noticed that dispose_ on that field was not being called. In most fields, including the super class, it is called dispose instead.
We've made this error in a few places:
field_angle
field_matrix
field_note
I also noticed this upstream in field_angle. @rachel-fenichel : is this just a typo/bug or am I missing something?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating field_angle, field_matrix, and field_note, then compare their dispose_ methods with the superclass's dispose method and the note picker field's disposal path. Confirm which method is invoked during cleanup and verify that all three fields use the expected method consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100