scratchfoundation / scratchfoundation/scratch-blocks

Explicitly Set Minimum Width for Hat Blocks

Open
#1,724 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement needs-triage
Dominant language
JavaScript
Stars
2.8k
Forks
1.6k
Avg merge
4h 51m
Merged PRs (30d)
12

Description

Current

Hat blocks have a rather unintentional min width. We do not see this issue in english, but other languages, such as Chinese have text widths that do not extend the block past the top arc of the hat.
screen shot 2018-10-01 at 3 44 34 pm

Proposal

We should extend the "brim" of the hat to be at least 6 units out from the top of the hat.

min-hat-block

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the hat-block rendering or layout entry point and reproduce the reported sizing difference with Chinese text. Compare the current brim width with the proposal and verify that hat blocks maintain at least 6 units of space beyond the top arc without breaking English or other localized text.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.