scratchfoundation / scratchfoundation/scratch-blocks

Angle picker number input has the minus sign on the wrong side (right) in RTL

Open
#1,709 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

help wanted High Prevalence High Severity localization priority 2
Dominant language
JavaScript
Stars
2.8k
Forks
1.6k
Avg merge
4h 51m
Merged PRs (30d)
12

Description

Expected Behavior

Numbers are still LTR in RTL languages (e.g. Hebrew).
When the angle picker switches to a negative input it should still have the minus sign on the left.

Note, if you type into the angle value (instead of using the picker) the minus sign also ends up on the right when it should be on the left.

Actual Behavior

2018-08-30 13 59 24
The minus sign is on the right as you move the angle picker, and the value is saved with the minus on the right after editing.

Steps to Reproduce

Use the angle picker in Hebrew

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the angle picker in Hebrew and tracing the number input behavior for both picker changes and direct typing. Done means negative angles display and save with the minus sign on the left, including values entered manually.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend, internationalization
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.