scratchfoundation / scratchfoundation/scratch-blocks

Comment from 2.0 project getting imported attached to the wrong block

Open
#1,705 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

compatibility needs-triage
Dominant language
JavaScript
Stars
2.8k
Forks
1.6k
Avg merge
4h 51m
Merged PRs (30d)
12

Description

Expected Behavior

Comments in 2.0 should be there in 3.0

Actual Behavior

Sometimes they aren't
screen shot 2018-08-29 at 4 20 45 pm
screen shot 2018-08-29 at 4 20 36 pm
(Some comments are tho!)

Steps to Reproduce

Can't reproduce. I tried creating comments, moving them to other blocks with and without deleting the original block, moving them to the scripts area and attaching it to a block again. Comments are always still there.

Found in
212388708

Operating System and Browser

MacOS, Chrome

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no source file or test; start by tracing the 2.0-to-3.0 comment import path in scratch-blocks and use revision 212388708 with the screenshots as context. Compare imports where comments are moved or their original block is deleted, and consider the work complete when each comment remains attached to its correct block.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.