scratchfoundation / scratchfoundation/scratch-blocks

Can't open a comment when it contains many CJK characters

Open
#1,680 3 comments 0 reactions 1 assignee View on GitHub

@kchadha is already working on this.

Since Aug 14, 2018.

Low Prevalence Medium Severity needs-triage priority 4
Dominant language
JavaScript
Stars
2.8k
Forks
1.6k
Avg merge
4h 51m
Merged PRs (30d)
12

Description

Expected Behavior

I can open a comment when clicking the button on the left side of the comment.

Actual Behavior

If a comment message contains some amount of CJK characters, the characters cover the open button. So I cannot open the comment.

I can't open a comment whose message is "あいうえお" x 10.

This bug does not happen when the message is long "abcdef...".

I can open a comment whose message is many "abcdef"s.

Steps to Reproduce
  1. Create a (block- or workspace-) comment.
  2. Copy and paste many あいうえお.
  3. Close the comment.
  4. Try to open the comment.
Operating System and Browser

Windows 10 Home, Google chrome 67.0.3396.99 (Official Build) (64 bit)
I tried on https://beta.scratch.mit.edu/ on Aug 2, 2018.


Moved from LLK/scratch-gui#2766
/cc @nekketsuuu @kchadha

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.