Localization: "stop" block doesn't allow SOV languages

Open
#1,579 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
48/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript
Domain
localization

Research direction

Start in blocks_vertical/control.js at the stop block code around line 206, and inspect how the stop label and dropdown are assembled. Compare the current ordering with the expected Japanese “XXXを止める” form and other SOV languages named in the issue. Done means the stop block displays the correct order for those languages without breaking the existing behavior.

Written by the indexing model from the issue text.

Description

localization needs-triage
Expected Behavior

In Japanese, stop block should be translated as "XXXを止める"
(Same for all languages using SOV such as Germany, Korean, Dutch, and more!)

Actual Behavior

According to the code it seems to be "を止めるXXX"

Steps to Reproduce

See the code

    this.appendDummyInput()
        .appendField('stop')
.appendField(stopDropdown, 'STOP_OPTION');

https://github.com/LLK/scratch-blocks/blob/develop/blocks_vertical/control.js#L206

Operating System and Browser

Windows 7 Home Premium 64bit SP1
Firefox 60.0.2

Dominant language
JavaScript
Stars
2.8k
Forks
1.6k
Avg merge
4h 51m
Merged PRs (30d)
12

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from scratchfoundation/scratch-blocks

All issues in scratchfoundation/scratch-blocks

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.