scratchfoundation / scratchfoundation/scratch-blocks

Palette scrolling doesn't take separetors height into account

Open
#1,303 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

help wanted
Dominant language
JavaScript
Stars
2.8k
Forks
1.6k
Avg merge
4h 51m
Merged PRs (30d)
12

Description

Expected Behavior

When adding a separtors to a toolbox, their height should be added to the height of the blocks when considering how much scrolling to allow.

Actual Behavior

It doesn't - when my palette height overflow the screen size, I can't scroll to the bottom blocks.

For example, there's no scroll bar at all here:

And here the scrolling doesn't go all the way to the bottom blocks:

Steps to Reproduce

add a big separator () to the top of a palette, and try scrolling to bottom.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with a palette containing a large separator such as and inspect how the palette calculates its scrollable height. Confirm the behavior with both the no-scrollbar and truncated-bottom-block examples. Done means separator height is included and scrolling reaches the bottom blocks.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.