scratchfoundation / scratchfoundation/scratch-blocks

"Input First" Blocks

Open
#1,206 1 comment 1 reaction 2 assignees View on GitHub

@picklesrus is already working on this.

Since Nov 2, 2018.

enhancement needs-triage
Dominant language
JavaScript
Stars
2.8k
Forks
1.6k
Avg merge
4h 51m
Merged PRs (30d)
12

Description

Some languages will reorder block parameters (e.g. Korean). This reordering can result in the inputs becoming the first element on the block. We will need to account for this by adding addtional vertical padding so the top notch of the block does not overlap the input.

Here are some initial sketches to address this issue. After sketching my leaning is towards the middle option: it balances adding some addtional padding help readability of block elements while not introducing a lot of vertical height to the blocks.

r1_input-first-blocks

This work is related to the Extension Icon on block work here: https://github.com/LLK/scratch-gui/issues/815

Reporters may need some special attention in both this case and Extension Icons as they also have some dynamic nesting logic: https://github.com/LLK/scratch-blocks/issues/522

My hope with the nesting reporters work was to limit the variability of horizontal / vertical growth for each block element (text, text-input, dropdown-input, boolean input...), which is a path that we could continue down, but open to alternative ideas.

cc/ @rachel-fenichel - If you have thoughts or are thinking about this in relation to Custom Procedures.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.