scrapy / scrapy/cssselect

HTML :enable and :disabled are not quite conformant

Open
#6 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

discuss
Dominant language
Python
Stars
310
Forks
70
Avg merge
2h 9m
Merged PRs (30d)
4

Description

These should match :enabled, but currently do not:

li elements that are children of menu elements, and that have a child element that defines a command, if the first such element's Disabled State facet is false (not disabled)

(Similarly for :disabled with Disabled State facet is true (disabled))

Form elements should be considered disabled

... if its disabled attribute is set, or if it is a descendant of a fieldset element whose disabled attribute is set and is not a descendant of that fieldset element's first legend element child, if any.

The last part was skipped, so the current implementation is:

... if its disabled attribute is set, or if it is a descendant of a fieldset element whose disabled attribute is set

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the implementation and tests for the :enabled and :disabled selectors; the issue provides the relevant HTML specifications as the expected behavior. Verify menu child commands and the fieldset disabled rule involving the first legend, then consider the work done when both selectors conform to those cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, html, python
Domain
web-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.