scrapy / scrapy/cssselect

Pseudo-element not at the end of a selector

Open
#144 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
310
Forks
70
Avg merge
2h 9m
Merged PRs (30d)
4

Description

Selectors like .something::before:hover are perfectly valid, but this library rejects them. Sure, they're not particularly useful for querying in offline contexts, but for parsing arbitrary stylesheets it would be useful to support them.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how the library parses and validates pseudo-elements in selectors such as .something::before:hover. Add coverage for this valid ordering and verify that arbitrary stylesheets containing it are accepted without breaking existing selector behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.