scrapinghub / scrapinghub/python-scrapinghub

Make msg_pack default

Open
#115 0 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Python
Stars
205
Forks
62
PR merge metrics
No merged PRs in 30d

Description

Considering the huge difference in performance, I propose to make it a default option.

It seems like it will require cleaning msg_pack not installled messages from the code, updating tests and setup.py\tox.

And docs.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing setup.py and tox configuration to see how msg_pack is currently treated, then search the code and tests for “msg_pack not installled” messages. The work is done when msg_pack is the default, those messages and related test expectations are updated, and the documentation reflects the new default.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.