scrapinghub / scrapinghub/dateparser
`RELATIVE_BASE` memory leak
Open
Nobody has claimed this yet.
Type: Enhancement
- Dominant language
- Python
- Stars
- 2.9k
- Forks
- 520
- Avg merge
- 22h 56m
- Merged PRs (30d)
- 6
Description
Minimal code:
from dateparser import parse
while True:
ret = parse('24 august', settings={'RELATIVE_BASE': datetime.now()})
Since for each new relative_base, a new settings object is created and cached, memory grows VERY quickly.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the minimal reproduction in the issue and inspect how settings objects are created and cached when RELATIVE_BASE changes. Confirm the memory growth with repeated unique relative bases, then identify the relevant regression-test location; done means repeated parsing no longer causes unbounded memory growth.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- performance
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100