scrapinghub / scrapinghub/dateparser
add date_formats parameter to DateDataParser
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 2.9k
- Forks
- 520
- Avg merge
- 22h 56m
- Merged PRs (30d)
- 6
Description
Splitting out from my comment in #939 :
from what I could tell, the DateDataParser does not accept a date_formats parameter, even in the settings dictionary, instead it looks like that must be passed through to the method called to parse the string, which seemed a bit unintuitive to me.
And here was the response from @noviluni:
Yeah, that's weird. In fact, the date_format is applied twice, before translating/cleaning and after if I remember correctly. Feel free to open a new issue and submit a PR with this change, it could be nice to have it :)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating DateDataParser and the method currently responsible for parsing the string, then trace how date_format is applied before and after translation or cleaning. Done should mean DateDataParser accepts date_formats through its settings dictionary and passes it through consistently to parsing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100