scrapinghub / scrapinghub/dateparser

Issue parsing ZH-Hant locale

Open
#875 1 comment 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
2.9k
Forks
520
Avg merge
22h 56m
Merged PRs (30d)
6

Description

Hi.

This doesn't work:
dateparser.parse('2020年9月1日 下午6:25', languages=['zh-Hant'])
This works:
dateparser.parse('2020年9月1日 下午6:25', languages=['zh'])
This also works:
dateparser.parse('2020年9月1日 下午6:25', languages=['zh-Hant', 'zh'])

It's weird because I can see all the info in https://github.com/scrapinghub/dateparser/blob/master/dateparser_data/cldr_language_data/date_translation_data/zh-Hant.json , but it also needs "zh" just to make it work.

Using latest 1.0.0 version, Python 3.8.

Thank you!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with dateparser.parse using the zh-Hant example from the report, then inspect dateparser_data/cldr_language_data/date_translation_data/zh-Hant.json and the locale-selection path. Done means the same Traditional Chinese date parses successfully with languages=['zh-Hant'] alone, without requiring 'zh'.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
internationalization
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.