scrapinghub / scrapinghub/dateparser
Leap Seconds cause parse failure
Open
Nobody has claimed this yet.
Type: Enhancement
- Dominant language
- Python
- Stars
- 2.9k
- Forks
- 520
- Avg merge
- 22h 56m
- Merged PRs (30d)
- 6
Description
import dateparser
# Passes:
assert dateparser.parse("December 31st, 2016 23:59:59 UTC") is not None
# Fails:
assert dateparser.parse("December 31st, 2016 23:59:60 UTC") is not None
Leap-seconds are important to my use case, and my understanding is that both timestamp-strings listed above are valid.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the two assertions in the issue and trace how dateparser handles the seconds field for UTC timestamps. Done means the leap-second example parses successfully while the existing 23:59:59 example continues to pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100