scrapinghub / scrapinghub/dateparser

Improve `settings`

Open
#796 3 comments 1 reaction 1 assignee View on GitHub

@noviluni is already working on this.

Since Sep 25, 2020.

Type: Enhancement
Dominant language
Python
Stars
2.9k
Forks
520
Avg merge
22h 56m
Merged PRs (30d)
6

Description

There are some bugs related to the settings that are hard to debug and some settings that aren't documented, so I think we should address this.

This is my plan:

  • Validate settings and raise an error if they are not valid (breaking change) [#797]
  • Possibly remove some settings? (breaking change) [#728, #794]
  • Document missed settings. [#722]
  • Check that all the settings are applying for each parser.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.