scrapinghub / scrapinghub/dateparser
parsing `midnight` gives the wrong day depending on the timezone
Open
Nobody has claimed this yet.
Type: Bug
- Dominant language
- Python
- Stars
- 2.9k
- Forks
- 520
- Avg merge
- 22h 56m
- Merged PRs (30d)
- 6
Description
when parsing midnight from timezone Europe/Paris (summer time GMT+2) between midnight and 2am, the date is off by one day.
I've created a branch with new tests as a showcase : https://github.com/thomasleveil/dateparser/tree/midnight_from_timezone
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the issue's linked midnight_from_timezone branch and its new tests to understand the expected behavior for Europe/Paris during summer time. Trace the parsing path those tests exercise, then confirm the date remains correct between midnight and 2am and that the relevant tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 50/100