scrapinghub / scrapinghub/dateparser

Parsing of "in 1h30m" fails

Open
#752 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Type: Enhancement
Dominant language
Python
Stars
2.9k
Forks
520
Avg merge
22h 56m
Merged PRs (30d)
6

Description

dateparser.parse('in 1h30m') is currently taken to mean 'at 01:30', instead of 'in 1 hour and 30 minutes'.

Using absolute time when the input starts with in .. seems completely wrong.

Initially reported here: https://github.com/anoadragon453/matrix-reminder-bot/issues/38

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with dateparser.parse('in 1h30m') and trace how inputs beginning with 'in' are classified. Confirm that the result represents a relative duration of one hour and 30 minutes rather than the absolute time 01:30, and add coverage for this input.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.