scrapinghub / scrapinghub/dateparser
Bad handling of non-integer relative dates
Open
Nobody has claimed this yet.
Type: Bug
- Dominant language
- Python
- Stars
- 2.9k
- Forks
- 520
- Avg merge
- 22h 56m
- Merged PRs (30d)
- 6
Description
In [67]: dateparser.parse('2.5h', settings={'PARSERS': ['relative-time'], 'PREFER_DATES_FROM': 'future'})
Out[67]: datetime.datetime(2020, 5, 10, 12, 44, 41, 394558)
In [68]: dateparser.parse('2,5h', settings={'PARSERS': ['relative-time'], 'PREFER_DATES_FROM': 'future'})
Out[68]: datetime.datetime(2020, 5, 10, 12, 44, 55, 313879)
In [69]: datetime.datetime.now()
Out[69]: datetime.datetime(2020, 5, 10, 7, 45, 4, 867612)
It should be 2.5h in the future, not 5h.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the reported dateparser.parse examples with the relative-time parser, then trace how decimal values such as 2.5h and 2,5h are interpreted. Done means both forms represent 2.5 hours in the future rather than 5 hours, with regression coverage for the reported behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100