scrapinghub / scrapinghub/dateparser

Parsing plain year numbers like "2024" with "PREFER..."-settings set to "last" returns wrong date. 1 day missing...

Open
#1,228 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
2.9k
Forks
520
Avg merge
22h 56m
Merged PRs (30d)
6

Description

print(dateparser.parse(
date_string="2024",
settings={"STRICT_PARSING": False,
"PREFER_DAY_OF_MONTH": "last",
"PREFER_MONTH_OF_YEAR": "last",
"PREFER_DATES_FROM": "past"}))
2024-12-30 00:00:00

It seems you're skipping a day. It should be 2024-12-31 00:00:00

...running on Macbook Air M2, Python 3.11 with

import locale
print(locale.getlocale())
(None, 'UTF-8')

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the dateparser.parse("2024") example with the listed PREFER_DAY_OF_MONTH, PREFER_MONTH_OF_YEAR, and PREFER_DATES_FROM settings. Trace how a plain year is expanded when both month and day preferences are set to "last"; done means the result is 2024-12-31 00:00:00 and the regression is covered by a test.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.