scrapinghub / scrapinghub/dateparser

German "Uhr" does not work

Open
#1,159 1 comment 5 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
2.9k
Forks
520
Avg merge
22h 56m
Merged PRs (30d)
6

Description

Hi,
it looks like full hours do not work, at least in German. For example, "18 Uhr" should be 2023-03-28 18:00 but it is 2023-03-18

>>> dateparser.parse("18 Uhr", languages=['de'], settings={'PREFER_DATES_FROM': 'future'})
datetime.datetime(2023, 3, 18, 0, 0)

Best!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with the shown dateparser.parse("18 Uhr", languages=['de'], settings={'PREFER_DATES_FROM': 'future'}) call and compare it with the expected 18:00 result. Trace the German parsing path from this entry point; done means full-hour German expressions return the correct date and time.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
localization
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.