scrapinghub / scrapinghub/dateparser

Thai year is not properly converted during parse

Open
#1,063 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
2.9k
Forks
520
Avg merge
22h 56m
Merged PRs (30d)
6

Description

Thai year is 543 days ahead of Gregorian calendar. However dateparser.parse is not taking care of this fact.
For example, '6 มิถุนายน 2554' should be converted to datetime.datetime(2011, 6, 6, 0, 0). However dateparser.parse('6 มิถุนายน 2554') returns datetime.datetime(2554, 6, 6, 0, 0).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the dateparser.parse entry point and trace how Thai-language dates and calendar years are interpreted. Verify the expected conversion for “6 มิถุนายน 2554” and add a regression test showing that it produces datetime.datetime(2011, 6, 6, 0, 0).

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
internationalization
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.