scrapinghub / scrapinghub/dateparser

`parse` parsing strings not matching `date_formats`

Open
#1,020 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Type: Documentation Type: Enhancement
Dominant language
Python
Stars
2.9k
Forks
520
Avg merge
22h 56m
Merged PRs (30d)
6

Description

Is this a bug, an undocumented feature, or maybe I didn't ready the docs thoroughly enough ?=/

In: dp.parse('Time', date_formats=['%d.%m.%Y %H:%M'])
Out: datetime.datetime(2021, 11, 19, 0, 0)

In: dp.parse('(m)', date_formats=['%d.%m.%Y %H:%M'])
Out[58]: datetime.datetime(2021, 11, 19, 0, 0)

I'd expect this to return None to be consistent when date_string doesn't match any date_formats.

In : dp.parse('something', date_formats=['%d.%m.%Y %H:%M'])
Out: None

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the public dp.parse entry point and reproduce the examples using the supplied date_formats. Trace why '(m)' produces a date despite not matching the format constraint. Done means nonmatching inputs return None while matching inputs retain their current behavior; add regression coverage wherever the repository's existing tests cover parse.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.