scp-fs2open / scp-fs2open/fs2open.github.com

Nebula Lightning triggers glTexSubImage3D() every time a lightning effect happens

Open
#7,035 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
487
Forks
184
PR merge metrics
PR metrics pending

Description

I discover this on the android-port / GLES path, im trying to confirm it happens on desktop gl as well, but i dont see any reason why it would be diferent in ES.
After testing several missions on ES and watching ingame use of glTexSubImage3D() seems to be limited to opening menus on regular missions after loading happens. But its diferent on nebula missions, as every lightning effect seems to trigger the texture upload every time.
On ES this is very bad because it triggers the pixel conversion format to adjust to formats supported on ES. But i would guess this may have an effect on weaker GPUs on desktop as well, like IGPs.

I dont know how the system works to investigate it more, and particually why the lightning textures arent being cached on load.

Note: for compressed textures, glCompressedTexSubImage3D() is called instead.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.