scp-fs2open / scp-fs2open/fs2open.github.com
(Minor) CC_preset Needs Refactor
Open
controls
good first issue
- Dominant language
- C++
- Stars
- 487
- Forks
- 184
- PR merge metrics
- PR metrics pending
Description
`CC_preset::type` wasn't fully implemented in an OOP compliant manner, and leaves behind a code smell.
The type shouldn't change between `hardcode` (not modifiable by users), `tbl` (.tbl defined, modifiable by campaign designers), or `pst` (.pst defined, modifiable by players). However, during duplication of a preset, a `hardcode` or `tbl` preset may be copied into a `pst` type.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.