scp-fs2open / scp-fs2open/fs2open.github.com

new hook deprecation version thresholds

Open
#5,200 2 comments 0 reactions 0 assignees View on GitHub
bug regression scripting
Dominant language
C++
Stars
487
Forks
184
Avg merge
3d 8h
Merged PRs (30d)
45

Description

The new hook deprecations added in #5184 use 23.0 as their threshold for becoming errors. What that means in practice is a mod targeting 23.0 as the -mod.tbm version setting, that runs perfectly fine on 23.0 stable, errors fatally on release builds in current nightlies.

In my mind this is incorrect behavior and those thresholds should be set to 23.1 or 23.2. Either that or some >= conditions should be > conditions. @BMagnu ?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.