scp-fs2open / scp-fs2open/fs2open.github.com

Pilot cloning is not a pure clone

Open
#4,004 0 comments 0 reactions 0 assignees View on GitHub
enhancement pilot file
Dominant language
C++
Stars
487
Forks
184
Avg merge
3d 9h
Merged PRs (30d)
44

Description

When cloning a pilot from the playermenu (The first player selection menu that the user sees), the clone is not a pure copy of the input pilot. Instead, a new pilot is created with the input pilot's control configuration and miscellaneous preferences with everything else effectively trashed.

This disrupts two workflows:
1. Player workflow, a new player may expect that the Clone process does exactly that, leading them to believe they could make a sort of save point in the campaign to pursue a risky option, then come back to the clone only to find they're punted back to the start of the campaign. (Needs Verification)
2. Tester workflow. A tester may expect that the clone process does exactly that. Since pilot file version variations are now a thing to worry about, a tester won't be able to safely clone a pilot from within an experimental build of FSO because the cloning process saves in the new format. A possible workaround to this is to instruct players to clone their pilot, and then use the clone instead of trying to use the parent.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.