scp-fs2open / scp-fs2open/fs2open.github.com

Changes to impact effects do not propegate to dinky explosions in modular tables

Open
#3,068 1 comment 0 reactions 0 assignees View on GitHub
bug graphics
Dominant language
C++
Stars
487
Forks
184
Avg merge
3d 9h
Merged PRs (30d)
44

Description

If a missile has an impact effect defined but not a dinky impact effect, then the dinky effect will be made to be the same as the regular effect. *But* this is only done if `first_time`, so if a missile is created, with or without an impact effect, and a modular table sets a new impact effect, the dinky effect will not be changed to match.

I have a missile affected by this, and checked my diagnosis by just removing the condition (on line ~1938 of weapons.cpp), but that is obviously not a viable actual solution. Logically, I think that if the dinky and impact explosion were the same before the impact was changed then most likely the dinky should be kept in sync, but I'm not sure that'll always be true.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.