scp-fs2open / scp-fs2open/fs2open.github.com

Setting standalone server title that is too long crashes standalone server, sort of

Open
#146 32 comments 0 reactions 0 assignees View on GitHub
bug discussion enhancement multi
Dominant language
C++
Stars
487
Forks
184
Avg merge
3d 9h
Merged PRs (30d)
44

Description

Tried to set an apparently too long title in the standalone, I got this in the standalone output (not in the log file, right on the console):

ERROR: "ERANGE: String error. Please Report. Trying to put into 33 byte buffer: SCP Test Server 20150517 (Retail)" at network/stand_gui-unix.cpp:408

The program never exited, but the WebUI stopped responding and it disappeared from FS2NetD shortly after, without having updated the title. The engine side should probably handle an attempt to set a long title more gracefully, and the WebUI should prevent attempting to set one too long. Whether that should be hardcoded or the engine can feed the UI with the limits dynamically should be investigated.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.