scottbez1 / scottbez1/splitflap
marking -DENABLE_DISPLAY as false won't compile
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 4.1k
- Forks
- 344
- PR merge metrics
- No merged PRs in 30d
Description
My TTGO is inside a case so the display isnt on (the display also broke) so I was wanting to turn it off, however when I mark -DENABLE_DISPLAY=false in platformio.ini this then means that it won't compile I get this error message
Compiling .pio/build/chainlink/src/Adafruit_INA219.cpp.o
firmware/esp32/splitflap/main.cpp:50:34: error: 'displayTask' was not declared in this scope
HTTPTask httpTask(splitflapTask, displayTask, serialTask, 0);
^
*** [.pio/build/chainlink/esp32/splitflap/main.cpp.o] Error 1
In file included from firmware/esp32/splitflap/display_task.cpp:21:0:
firmware/esp32/splitflap/display_layouts.h:56:13: warning: 'void getLayoutPositionDualRowZigZag(bool, uint8_t, uint8_t*, uint8_t*)' defined but not used [-Wunused-function]
static void getLayoutPositionDualRowZigZa
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the ENABLE_DISPLAY setting in platformio.ini and the displayTask reference in firmware/esp32/splitflap/main.cpp. Compare that with firmware/esp32/splitflap/display_task.cpp and display_layouts.h to understand the disabled-display build path. Done means the project compiles successfully with ENABLE_DISPLAY=false.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- arduino, cpp
- Domain
- build-system, embedded-iot
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 50/100