scottbez1 / scottbez1/splitflap

Post modified artifacts to PRs for review

Open
#137 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area: tooling type: enhancement
Dominant language
JavaScript
Stars
4.1k
Forks
344
PR merge metrics
No merged PRs in 30d

Description

Set up a workflow_run workflow to download PR artifacts and post a comment back to the PR which shows artifacts that may have changed, as described here: https://securitylab.github.com/research/github-actions-preventing-pwn-requests

Could either run an image diff on the rasterized artifacts compared to the base revision's artifacts, or just review which file paths were modified in the diff and include all artifacts that depend on those files. Image diff increases security risk (e.g. potential malicious image artifact could be manually generated to compromise image diff program) and is more complicated, so probably best to just filter which artifacts to post based on which file paths were modified and accept that this may include artifacts that are unchanged.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the linked GitHub Security Lab guidance on workflow_run workflows and review the repository's existing GitHub Actions configuration, if present. Define the workflow's artifact download, PR association, changed-path filtering, and comment behavior; done means a PR receives the relevant artifacts for review without exposing the workflow to the security risks described.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions
Domain
ci-cd, devops
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.