Please document relevance of space servers

Open
#296 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
35/100
Issue type
Documentation
Clarity
Mostly clear
Activity status
Stale
Tech stack
docker, php, shell
Domain
devops, documentation

Research direction

Start with s2i/bin/run at the referenced line and inspect how the server count is increased by 10. Check how this behaves when max workers is very small, such as 12, and identify where this rationale should be documented. Done means the documentation explains the purpose and relevance of the value and its behavior for small worker settings.

Written by the indexing model from the issue text.

Description

We had been looking at this line and we where wondering if there is the need to improve this line https://github.com/sclorg/s2i-php-container/blob/80ac275d1faaee110813ac70857adfc524a95f05/7.3/s2i/bin/run#L37 .

The start servers are increased by +10. The value seems to be random and maybe not correct if you handle tiny max workers (The setting might be 12). I would a happy if you could add more information on this topic.

Dominant language
Shell
Stars
114
Forks
326
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from sclorg/s2i-php-container

All issues in sclorg/s2i-php-container

Similar issues

More Shell/Bash issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.