scipp / scipp/scippnexus

Label-based indexing for NXlog with sublogs

Open
#233 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
6
Forks
5
PR merge metrics
No merged PRs in 30d

Description

This is currently not supported, see https://github.com/scipp/scippnexus/blob/e33f2f4bb2a7843a5ed7fd31fc1761a6408c262e/src/scippnexus/nxdata.py#L493-L499. As all ESS files seem to have such sublogs we will either be stuck with loading the entire log, or maybe provide a custom application definition when loading NXlog to drop the offending sublogs. Or the mechanism needs to be added, but this may be complicated?

See also #232.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read src/scippnexus/nxdata.py around lines 493-499 and compare the related discussion in issue #232. Determine how NXlog sublogs currently affect label-based indexing and define the expected behavior for ESS files, including whether sublogs should be loaded or dropped. Done means label-based indexing works for NXlog files containing sublogs without the current limitation.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.